Shell: only its own replies, Apps by their names, and rm as Unix has it (#67)
CI / build (pull_request) Successful in 1m38s
Site / build (pull_request) Successful in 10s

The Shell shows the replies to its own commands and nothing else. The
console knows who each line is printed for (Console::As, Console::origin):
a command run from the Shell prints as the Shell's, and what answers it
later from another task carries that along (ls, tasks, du, cp, update
check, sd list, screenshot, gemini get). Ctrl+b shows everything instead.
This replaces the ten-second window, which was a guess.

An App's name with a capital opens it (Notes, Irc, Wifi, Gnss, Gemini, Lora,
Storage, Shell, System, Settings), from the Shell and from the consoles.

rm needs -r for a folder, here and over the consoles. In the Shell a file,
or a folder with something in it, is asked about unless -f; an empty folder
with -r goes without a word.

The Shell now hands its line to the main loop to run: run from inside the
key handler, rm on a folder overflowed the loop's stack and crashed the
device. `info` says which App is in front.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EhqxQ49eCju4CzKYNjZzwT
This commit is contained in:
2026-10-07 11:35:29 +02:00
co-authored by Claude Opus 5.5
parent 3863d28593
commit 7b5df713ad
24 changed files with 414 additions and 124 deletions
+23 -2
View File
@@ -34,10 +34,30 @@ class Console : public Print {
// The ring only, for output that already reaches the serial port another way.
void toRing(const uint8_t* data, size_t len);
// A second ring of the same kind, for the Shell App (issue #67): open while the App is, so that
// it can show what the console prints. The two don't know of each other.
// Who asked for what is being printed. A command typed in the Shell App prints its reply `As`
// the Shell, and so does whatever answers it later from another task (a listing read by the
// storage task, `tasks` a second on): the one that starts the work notes origin() and the one that
// prints takes it back. Everything else is the System's: logs, and the consoles' own commands.
enum class Origin : uint8_t { System, Shell };
Origin origin() const; // of the task that asks, now
class As {
public:
explicit As(Origin origin);
~As();
As(const As&) = delete;
As& operator=(const As&) = delete;
private:
bool entered_;
};
// A second ring of the same kind, for the Shell App (issue #67): open while the App is. It gets
// what is printed As the Shell, and nothing else, so that the Shell shows the replies to its own
// commands and not the rest (Q206); or everything, when asked.
bool openShellRing();
void closeShellRing();
void shellShowsAll(bool all) { shellAll_ = all; }
bool shellShowsAll() const { return shellAll_; }
size_t readShellSince(uint32_t& pos, uint8_t* out, size_t max, uint32_t& skipped);
private:
@@ -45,6 +65,7 @@ class Console : public Print {
uint32_t head_ = 0; // total bytes written since the ring opened; it holds the last kRingBytes of them
uint8_t* shellRing_ = nullptr;
uint32_t shellHead_ = 0;
volatile bool shellAll_ = false;
};
extern Console console;